From 3c3b580496eb3c24fca9c7fd4cc06f26e011692c Mon Sep 17 00:00:00 2001 From: Liam Steckler Date: Sat, 10 Feb 2024 20:22:10 -0800 Subject: [PATCH] Fix bare excepts --- kuow_fetcher.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kuow_fetcher.py b/kuow_fetcher.py index e7b8f83..98590cd 100644 --- a/kuow_fetcher.py +++ b/kuow_fetcher.py @@ -1,5 +1,6 @@ import json from datetime import datetime +from json.decoder import JSONDecodeError from typing import Optional import requests @@ -70,7 +71,7 @@ with Session(engine) as session: schema_org = json.loads(schema_org_scriptblock.text) assert schema_org["@context"] == "http://schema.org" last_updated_time = datetime.fromisoformat(schema_org["dateModified"]) - except: + except (AssertionError, JSONDecodeError): print( "Could not find or load schema.org data for this post, looking up the meta published time" ) @@ -80,7 +81,7 @@ with Session(engine) as session: "meta", attrs={"property": "article:published_time"} )["content"] ) - except: + except NameError: print("Could not find or load the meta published time for this post") last_updated_time = datetime.now() @@ -106,14 +107,14 @@ with Session(engine) as session: article_record.dfp_targeting_id = article_soup.find( "script", {"class": "dfp_targeting", "data-key": "id"} )["data-value"] - except: + except NameError: print("Could not find or load IDs for this post") try: tags = article_soup.find( "script", {"class": "dfp_targeting", "data-key": "tags"} )["data-value"].split("|") - except: + except NameError: print("Could not find or load any tags for this article") tags = [] @@ -141,7 +142,7 @@ with Session(engine) as session: article_record.post_id = mastodon_post_result["id"] else: print("Article has already been posted") - except: + except Exception: print("Could not load a description/post this article") article_record.article_link = article_link